Skip to content

fix(mock-connection): use muxer to close/abort streams #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(mock-connection): use muxer to close/abort streams #2769

wants to merge 2 commits into from

Conversation

tabcat
Copy link
Contributor

@tabcat tabcat commented Oct 13, 2024

Title

fix(mock-connection): use muxer to close/abort streams

Description

Uses this.muxer.close and this.muxer.abort in MockConnection's close and abort methods.

Notes & open questions

Fixes #2675

I looked at a541748 to see if there was a reason this was done but did not see one.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@tabcat tabcat requested a review from a team as a code owner October 13, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mock connection doesn't close stream muxer
1 participant
@tabcat